Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bc, figlet: add Spanish translation #6208

Merged
merged 2 commits into from Jul 9, 2021
Merged

bc, figlet: add Spanish translation #6208

merged 2 commits into from Jul 9, 2021

Conversation

victorhck
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2021

CLA assistant check
All committers have signed the CLA.

@navarroaxel navarroaxel added the translation Translate pages from one language to another. label Jul 8, 2021
@navarroaxel navarroaxel changed the title bc, figlet: add spanish translation bc, figlet: add Spanish translation Jul 9, 2021
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @victorhck, welcome and thanks for your submission. I left some comments.

pages.es/common/bc.md Outdated Show resolved Hide resolved
pages.es/common/bc.md Outdated Show resolved Hide resolved
pages.es/common/bc.md Outdated Show resolved Hide resolved
pages.es/common/bc.md Outdated Show resolved Hide resolved
pages.es/common/figlet.md Outdated Show resolved Hide resolved
pages.es/common/figlet.md Outdated Show resolved Hide resolved
pages.es/common/figlet.md Outdated Show resolved Hide resolved
pages.es/common/figlet.md Outdated Show resolved Hide resolved
pages.es/common/figlet.md Outdated Show resolved Hide resolved
pages.es/common/figlet.md Outdated Show resolved Hide resolved
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@victorhck
Copy link
Contributor Author

victorhck commented Jul 9, 2021

Hi @victorhck, welcome and thanks for your submission. I left some comments.

Thanks...
So, sorry for the noise!! Next time hope to do better...

Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak Spanish however looks alright

Comment on lines +18 to +20
- Muestra las fuentes disponibles para figlet:

`showfigfonts {{texto_opcional_a_mostrar}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the en has it however should it be here? (and on the other one)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, appears in English file, that's why included here.
I think it's related in some way with figlet. And thanks to be included here it's how I found that this command exits! :)
I'm a newcomer here, but I find it useful...

@navarroaxel navarroaxel merged commit 2219faa into tldr-pages:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants