Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-help: add page #6446

Merged
merged 6 commits into from Sep 4, 2021
Merged

aws-help: add page #6446

merged 6 commits into from Sep 4, 2021

Conversation

lydianeU
Copy link
Contributor

@lydianeU lydianeU commented Aug 31, 2021 •
edited

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@lydianeU lydianeU marked this pull request as ready for review August 31, 2021 18:52
nicokosi
nicokosi approved these changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@nicokosi nicokosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. 👍

@nicokosi nicokosi mentioned this pull request Aug 31, 2021
Open
blueskyson
blueskyson reviewed Sep 1, 2021
View reviewed changes
pages/common/aws-help.md Outdated Show resolved Hide resolved
mfrw
mfrw reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lydianeU Thank you for you contribution :)

@tldr-bot

This comment has been minimized.

Sign in to view
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Sep 1, 2021
navarroaxel
navarroaxel reviewed Sep 1, 2021
View reviewed changes
pages/common/aws-help.md Outdated Show resolved Hide resolved
pages/common/aws-help.md Outdated Show resolved Hide resolved
@CleanMachine1
Copy link
Member

CleanMachine1 commented Sep 3, 2021 •
edited

@lydianeU I'm aware it has only been 3 days however most of the reviewers and active maintainers have given their suggestions, so the next stage is you approving and committing the suggestions, thanks for the contribution anyway!

lydianeU and others added 4 commits September 3, 2021 23:56
@lydianeU @CleanMachine1
Update pages/common/aws-help.md
a55da56 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@lydianeU @blueskyson
Update pages/common/aws-help.md
b8659ee 
Co-authored-by: lincc <46962923+blueskyson@users.noreply.github.com>
@lydianeU @navarroaxel
Update pages/common/aws-help.md
a48b332 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@lydianeU @navarroaxel
Update pages/common/aws-help.md
6754392 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@lydianeU
Copy link
Contributor Author

lydianeU commented Sep 3, 2021

@CleanMachine1 I was afk, that's fixed ^^

@lydianeU lydianeU closed this Sep 4, 2021
@lydianeU lydianeU reopened this Sep 4, 2021
marchersimon
marchersimon approved these changes Sep 4, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lydianeU

@marchersimon marchersimon merged commit 41b497b into tldr-pages:main Sep 4, 2021
@lydianeU lydianeU deleted the issue#5653-aws-help-add-page branch September 4, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw mfrw left review comments

@blueskyson blueskyson blueskyson left review comments

@nicokosi nicokosi nicokosi approved these changes

@marchersimon marchersimon marchersimon approved these changes

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lydianeU @CLAassistant @tldr-bot @CleanMachine1 @navarroaxel @nicokosi @mfrw @blueskyson @marchersimon