Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

masscan: add page #6986

Merged
merged 10 commits into from Oct 17, 2021
Merged

masscan: add page #6986

merged 10 commits into from Oct 17, 2021

Conversation

ciph3rz
Copy link
Contributor

@ciph3rz ciph3rz commented Oct 13, 2021 •
edited by navarroaxel

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

@CLAassistant

This comment has been minimized.

Sign in to view
@tldr-bot

This comment has been minimized.

Sign in to view
@navarroaxel navarroaxel changed the title Added masscan.md to tldr masscan: add page Oct 13, 2021
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 13, 2021
@tldr-bot

This comment has been minimized.

Sign in to view
navarroaxel
navarroaxel requested changes Oct 13, 2021
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ciph3rz, welcome and thanks for your submission. I left some comments.

pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
pages/common/masscan.md Outdated Show resolved Hide resolved
@tldr-bot

This comment has been minimized.

Sign in to view
ciph3rz
ciph3rz commented Oct 13, 2021
View reviewed changes
Copy link
Contributor Author

@ciph3rz ciph3rz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added suggested changes.

mfrw
mfrw reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetic :)

pages/common/masscan.md Outdated Show resolved Hide resolved
mfrw
mfrw approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ciph3rz thank you for your contribution

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/masscan.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

sbrl
sbrl approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 more minor comment! Thanks for sticking with the review process here :D

pages/common/masscan.md Outdated Show resolved Hide resolved
@ciph3rz @sbrl
Update pages/common/masscan.md
27216b6 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel navarroaxel merged commit 7c85dd0 into tldr-pages:main Oct 17, 2021
@ciph3rz
Copy link
Contributor Author

ciph3rz commented Oct 29, 2021

#6863

@navarroaxel navarroaxel mentioned this pull request Oct 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@navarroaxel navarroaxel navarroaxel approved these changes

@mfrw mfrw mfrw approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ciph3rz @CLAassistant @tldr-bot @navarroaxel @mfrw @sbrl @CleanMachine1