Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smbmap: add page #7053

Merged
merged 14 commits into from Nov 21, 2021
Merged

smbmap: add page #7053

merged 14 commits into from Nov 21, 2021

Conversation

ciph3rz
Copy link
Contributor

@ciph3rz ciph3rz commented Oct 17, 2021

  • [ x] The page (if new), does not already exist in the repository.
  • [ x] The page is in the correct platform directory (common/, linux/, etc.)
  • [ x] The page has 8 or fewer examples.
  • [ x] The PR title conforms to the recommended templates.
  • [x ] The page follows the content guidelines.
  • [ x] The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

For #6863

@ciph3rz ciph3rz changed the title Smb map Smbmap Oct 17, 2021
@ciph3rz
Copy link
Contributor Author

ciph3rz commented Oct 17, 2021

Looks like my masscan.md contribution is causing a conflict. I'm still new to git so any assistance (commands to run) to get this corrected would be appreciated!

@navarroaxel
Copy link
Member

I think you create a branch from masscan instead of main. But it's easy to fix.

@navarroaxel navarroaxel changed the title Smbmap smbmap: add page Oct 17, 2021
@tldr-bot

This comment has been minimized.

pages/common/SMBMap.md Outdated Show resolved Hide resolved
pages/common/SMBMap.md Outdated Show resolved Hide resolved
pages/common/SMBMap.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 17, 2021
@tldr-bot

This comment has been minimized.

pages/common/smbmap.md Outdated Show resolved Hide resolved
pages/common/smbmap.md Outdated Show resolved Hide resolved
pages/common/smbmap.md Show resolved Hide resolved
pages/common/smbmap.md Outdated Show resolved Hide resolved
pages/common/smbmap.md Outdated Show resolved Hide resolved
pages/common/smbmap.md Outdated Show resolved Hide resolved
pages/common/smbmap.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel requested a review from sbrl October 21, 2021 02:33
@ciph3rz
Copy link
Contributor Author

ciph3rz commented Oct 26, 2021

#6863

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

Also, is there a way to scan an IP address range, or is that something you'd do with another tool (e.g. massscan)?

pages/common/smbmap.md Outdated Show resolved Hide resolved
pages/common/smbmap.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 30, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Nov 15, 2021
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel navarroaxel removed the waiting Issues/PRs with Pending response by the author. label Nov 20, 2021
@marchersimon marchersimon merged commit da2545c into tldr-pages:main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants