New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-ses: add page #7136
aws-ses: add page #7136
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page! I've left some comments below for you to review.
pages/common/aws-ses.md
Outdated
@@ -0,0 +1,37 @@ | |||
# aws ses | |||
|
|||
> CLI for AWS SES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we expand on SES
please? Amazon Web Services provide a truly staggering number of services, so it's difficult to know which service this it at first glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I'll update this to describe what the acronym stands for, thanks for the comment.
pages/common/aws-ses.md
Outdated
> High-scale inbound and outbound cloud email service. | ||
> More information: <https://awscli.amazonaws.com/v2/documentation/api/latest/reference/ses/index.html>. | ||
|
||
- Show help for specific SES subcommand: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this will read better?
- Show help for specific SES subcommand: | |
- Show help for a specific SES subcommand: |
Also, this example should be at the bottom of the page.
pages/common/aws-ses.md
Outdated
|
||
- Send email: | ||
|
||
`aws ses send-email --from {{from_address}} --destination "ToAddresses={{addresses}}" --message "Subject={Data={{subject_text}},Charset=utf8},Body={Text={Data={{body_text}},Charset=utf8},Html={Data={{}},Charset=utf8}}"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the {{}}
in Html={Data={{}},
a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, yes it is, I'll add the placeholder text. It should be same as the other Data
arguments.
Apply suggestions from code review to improve readability. Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
This comment has been minimized.
This comment has been minimized.
Move help command to bottom of the list as per suggestion in PR review.
b1872a3
to
b50a28c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @shermanhui!
Can't tell if you force-pushed or whether the view changes button is broken on my end haha
@sbrl I think I might have force-pushed after the bot indicated I missed a new line at the end of the file 😅 I didn't think it warranted a separate commit merely to add a newline at the end of file 🙏🏻 |
common/
,linux/
, etc.)Version of the command being documented (if known):
version 2010-12-01