Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ses: add page #7136

Merged
merged 4 commits into from Nov 7, 2021
Merged

aws-ses: add page #7136

merged 4 commits into from Nov 7, 2021

Conversation

shermanhui
Copy link
Contributor

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):
version 2010-12-01

@tldr-bot

This comment has been minimized.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 22, 2021
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

@@ -0,0 +1,37 @@
# aws ses

> CLI for AWS SES.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we expand on SES please? Amazon Web Services provide a truly staggering number of services, so it's difficult to know which service this it at first glance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll update this to describe what the acronym stands for, thanks for the comment.

> High-scale inbound and outbound cloud email service.
> More information: <https://awscli.amazonaws.com/v2/documentation/api/latest/reference/ses/index.html>.

- Show help for specific SES subcommand:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will read better?

Suggested change
- Show help for specific SES subcommand:
- Show help for a specific SES subcommand:

Also, this example should be at the bottom of the page.

pages/common/aws-ses.md Outdated Show resolved Hide resolved
pages/common/aws-ses.md Outdated Show resolved Hide resolved
pages/common/aws-ses.md Outdated Show resolved Hide resolved
pages/common/aws-ses.md Outdated Show resolved Hide resolved
pages/common/aws-ses.md Outdated Show resolved Hide resolved
pages/common/aws-ses.md Outdated Show resolved Hide resolved
pages/common/aws-ses.md Outdated Show resolved Hide resolved

- Send email:

`aws ses send-email --from {{from_address}} --destination "ToAddresses={{addresses}}" --message "Subject={Data={{subject_text}},Charset=utf8},Body={Text={Data={{body_text}},Charset=utf8},Html={Data={{}},Charset=utf8}}"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the {{}} in Html={Data={{}}, a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes it is, I'll add the placeholder text. It should be same as the other Data arguments.

@navarroaxel navarroaxel added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 30, 2021
Apply suggestions from code review to
improve readability.

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@tldr-bot

This comment has been minimized.

Move help command to bottom of the list as per
suggestion in PR review.
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shermanhui!

Can't tell if you force-pushed or whether the view changes button is broken on my end haha

@sbrl sbrl added the review needed Prioritized PRs marked for reviews from maintainers. label Nov 4, 2021
@shermanhui
Copy link
Contributor Author

@sbrl I think I might have force-pushed after the bot indicated I missed a new line at the end of the file 😅 I didn't think it warranted a separate commit merely to add a newline at the end of file 🙏🏻

@navarroaxel navarroaxel merged commit b2d6839 into tldr-pages:main Nov 7, 2021
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants