Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ytfzf: add page #7458

Merged
merged 3 commits into from Nov 28, 2021
Merged

ytfzf: add page #7458

merged 3 commits into from Nov 28, 2021

Conversation

kyteinsky
Copy link
Contributor

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known): 1.2.0

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Nov 18, 2021
navarroaxel
navarroaxel previously requested changes Nov 18, 2021
View reviewed changes
pages/linux/ytfzf.md Outdated Show resolved Hide resolved
pages/linux/ytfzf.md Outdated Show resolved Hide resolved
pages/linux/ytfzf.md Outdated Show resolved Hide resolved
pages/linux/ytfzf.md Outdated Show resolved Hide resolved
pages/linux/ytfzf.md Outdated Show resolved Hide resolved
pages/linux/ytfzf.md Outdated Show resolved Hide resolved
@kyteinsky
Copy link
Contributor Author

I'll commit the changes, but was just curious why use the long args when short ones are easier to use and suit tldr better?

@navarroaxel
Copy link
Member

I'll commit the changes, but was just curious why use the long args when short ones are easier to use and suit tldr better?

  1. Easier to infer what does each argument in the example without read the man page.
  2. Easier to remember than two or three random letters.

@kyteinsky
Copy link
Contributor Author

Yeah makes sense. After all, they'll be looking at the thing for the first time, so long arguments would be good.

sbrl
sbrl requested changes Nov 25, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

pages/linux/ytfzf.md Outdated

`ytfzf --show-thumbnails {{search_pattern}}`

- Play only audio of first item in loop:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will read better?

Suggested change
- Play only audio of first item in loop:
- Play only the audio of the first item in a loop:

pages/linux/ytfzf.md Outdated
> A POSIX script that helps you find and download videos and music.
> More information: <https://github.com/pystardust/ytfzf>.

- Search videos in YouTube and display the thumbnails:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will read better?

Suggested change
- Search videos in YouTube and display the thumbnails:
- Search for videos on YouTube and display the thumbnails:

pages/linux/ytfzf.md Outdated

`ytfzf --audio-only --auto-select --loop {{search_pattern}}`

- Download a video from history:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will read better?

Suggested change
- Download a video from history:
- Download a video from the history:

pages/linux/ytfzf.md Outdated

`ytfzf --download --choose-from-history`

- Play all the music found in one search:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will read better?

Suggested change
- Play all the music found in one search:
- Play all the music found in a search:

pages/linux/ytfzf.md Outdated

`ytfzf --audio-only --select-all {{search_pattern}}`

- See the trending videos in external menu:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this will read better?

Suggested change
- See the trending videos in external menu:
- See the trending videos in an external menu:

@kyteinsky
Copy link
Contributor Author

Ahh those articles 😐

@kyteinsky
Copy link
Contributor Author

Please squish the commits.

sbrl
sbrl approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kyteinsky!

Yeah, we have a special button in the GitHub web interface to squash on merge :D

@sbrl sbrl added the review needed Prioritized PRs marked for reviews from maintainers. label Nov 25, 2021
@kyteinsky
Copy link
Contributor Author

Yeah, we have a special button in the GitHub web interface to squash on merge :D

That's nice to know :)

@CleanMachine1 CleanMachine1 merged commit d3e2dc9 into tldr-pages:main Nov 28, 2021
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

@navarroaxel navarroaxel navarroaxel left review comments

@marchersimon marchersimon Awaiting requested review from marchersimon

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyteinsky @navarroaxel @sbrl @CleanMachine1