Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android exoplayer #88

Merged
merged 18 commits into from
Oct 1, 2017
Merged

Android exoplayer #88

merged 18 commits into from
Oct 1, 2017

Conversation

cherniv
Copy link

@cherniv cherniv commented Apr 23, 2017

Method getStatus response includes duration and progress

@tlenclos
Copy link
Owner

tlenclos commented May 7, 2017

Hi @cherniv
Thanks a lot for your work, I will try to make a minor release with bugfixes without exoplayer and then a major release with it.

Could you fix the indentation issues so that we can read the diff properly ?

@vshjxyz
Copy link

vshjxyz commented May 8, 2017

Hey guys, I've had a bit of a play on @cherniv's branch, adding "pause on bluetooth disconnect" "pause when removing headphones" and other fixes, will try to build a PR against this branch so you can check it out - works great tho! nice job

@cherniv
Copy link
Author

cherniv commented May 8, 2017

@tlenclos i really don't know what happened with the indentations.. i've used both xcode and sublime and looks like they are messing up files formations. what can be done to fix it ? i'm not sure i want to pass on it manually if this is the only solution..
@vshjxyz cool!

@tlenclos
Copy link
Owner

tlenclos commented May 8, 2017

@cherniv you could just revert the changes with git, using a GUI for example.

@cherniv
Copy link
Author

cherniv commented May 12, 2017

@tlenclos sorry I'm not a big git master. Do you mean I have to choose bad lines from problematic commits and revert them and then create new commit and push it to my forked repo?

@tlenclos
Copy link
Owner

@cherniv Yes please. Otherwise it's just too hard to see exactly your changes.

@cherniv
Copy link
Author

cherniv commented May 19, 2017

@tlenclos hey, can you see if it is better now? thanks

@catalinmiron
Copy link

any progress?

@tlenclos
Copy link
Owner

tlenclos commented Oct 1, 2017

@cherniv thanks for all your work, I will merge and start from this

@tlenclos tlenclos merged commit 5f2926a into tlenclos:android-exoplayer Oct 1, 2017
@cherniv cherniv deleted the android-exoplayer branch October 1, 2017 17:42
@tmaly1980
Copy link

@tlenclos What's required to merge this branch with master? Or in the meantime, can I simply use this branch in my project?

@guiyom19
Copy link

Will it be a 2.3.3 release with this exoplayer branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants