Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of resume/play function #9

Merged
merged 2 commits into from
Aug 5, 2016
Merged

Better handling of resume/play function #9

merged 2 commits into from
Aug 5, 2016

Conversation

brettpappas
Copy link
Collaborator

Use the resume feature only if it is in paused state AND the streamUrl hasn't changed. Otherwise, use play function which stops any previously queued item.

Add new property to keep track of last audio file played
@tlenclos
Copy link
Owner

tlenclos commented Aug 5, 2016

Thanks, have you looked this on android also ?

Also would you like to be added as a core contributor to manage branch, pull requests and releases with me ?

@brettpappas
Copy link
Collaborator Author

Sure, I would be happy to help manage the repository. As for android, I can definitely appreciate the need to keep both platforms in sync. I was just trying to shape a few areas that I think need addressed and then maybe we could catch android up once that is established.

The areas I would like to improve first are:

  1. seek functions
  2. progress bar
  3. handling multiple audio streams

I think I have a good start on each of these and I will try to build out a working demo as soon as I can.

Once that is done, I can go back and do the same for android (with your help).

Then maybe phase two could be a few other nice to have features:

  1. Update iOS Command Center with things like progress bar, title, pause button. I know it gets updated now if the mp3 file has metadata but it would be nice to be able to pass custom titles as well.
  2. Full screen player component where someone can pass props for enabling or disabling certain UI features like artwork, seek buttons (15 sec, 30 sec, etc..)

@tlenclos
Copy link
Owner

tlenclos commented Aug 5, 2016

You are right and we could merge all your work on iOS now, refactor the old code on android with ExoPlayer before starting to implement the same functionalities.

I think I will focus my time on the android side for now since you seem to handle the iOS part pretty well 😄 .

@tlenclos tlenclos merged commit fa4ad8d into tlenclos:master Aug 5, 2016
@brettpappas brettpappas deleted the patch-4 branch October 28, 2016 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants