Set State fix and Manual Metadata Definition #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radicalnerds
commented
May 5, 2017
radicalnerds
commented
- Fix setState call when unmounted
- Add Title metadata on Play
- Add Artwork Metadata on Play
- Default to BundleDisplayName then BundleName
added 2 commits
April 25, 2017 13:24
- Display Name from Bundle Display Name - Title - Artwork
tlenclos
reviewed
May 7, 2017
| [songInfo setValue:albumArt forKey:MPMediaItemPropertyArtwork]; | ||
| infoCenter.nowPlayingInfo = songInfo; | ||
| } | ||
| self.fetchedAlbumArt = true; |
There was a problem hiding this comment.
It seems that with your implementation you can only fetch the first song artwork, what happens if a new song from an other album is playing ?
tlenclos
reviewed
May 7, 2017
| @@ -49,10 +49,15 @@ class Player extends Component { | |||
| ); | |||
|
|
|||
| ReactNativeAudioStreaming.getStatus((error, status) => { | |||
| console.log('Status', status); | |||
tlenclos
reviewed
May 7, 2017
| @@ -27,10 +27,10 @@ - (ReactNativeAudioStreaming *)init | |||
| [self.audioPlayer setDelegate:self]; | |||
| self.lastUrlString = @""; | |||
| [NSTimer scheduledTimerWithTimeInterval:0.5 target:self selector:@selector(tick:) userInfo:nil repeats:YES]; | |||
|
|
|||
There was a problem hiding this comment.
Don't commit indentation changes plz
|
@radicalnerds thanks for your work, it looks cool and supporting album cover could be really cool 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.