-
Notifications
You must be signed in to change notification settings - Fork 31
5.3.0 doesn't work with eslint-plugin-import #117
Comments
Thank you for reporting the issue @adp-psych. Here are the changes between the 2 versions btw: v5.2.0...v5.3.0 Interestingly, I also just notice 5.3.0 should have been a major update because of the node 10 requirement now. But we'll soon force node 12 anyway so I'll make sure to make a major release then. |
Hi @tleunen! Thanks for your quick response. I investigated as you requested, and it seems the problem is here:
When this runs, Commenting out this line and the |
Thanks for investigating this! |
@adp-psych @tleunen I tried to setup a minimal project with your config but I think I need further files. I added all deps and then get this error: Error: Error while loading rule 'notice/notice': Can't find templateFile @ /Users/foo/Desktop/test-module-resolver/templates/copyright.js Do you have a minimal failing example? Also, I guess it is maybe related to the importing statement rather than the config (don't know though). |
@dword-design, my ESLint configuration expects
|
@adp-psych Alright I could reproduce the issue. Coming up with a fix soon. |
@adp-psych @tleunen This PR fixes the issue #118. Problem was basically that the NPM import test was too specific for only testing babel plugin resolution. I replaced it with |
That's good to know! Thank you @dword-design for the explanation, and the fix :) |
Version 5.3.0 of eslint-import-resolver-babel-module causes problems for me with eslint-plugin-import:
Downgrading to version 5.2.0 of eslint-import-resolver-babel-module (
npm install --no-save eslint-import-resolver-babel-module@5.2.0
) resolves the problem.Here's my
babel.config.js
(with comments removed):My full Babel and ESLint configurations are on npm as @adp-psych/babel-config and @adp-psych/eslint-config.
The text was updated successfully, but these errors were encountered: