Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

feat: Add support for Babel 7.0.0 #63

Merged
merged 4 commits into from
Oct 10, 2017
Merged

feat: Add support for Babel 7.0.0 #63

merged 4 commits into from
Oct 10, 2017

Conversation

nodkz
Copy link
Contributor

@nodkz nodkz commented Jul 13, 2017

memoisedPlugins does not exists in Babel 7.0.0
So I'm traversing plugins by its keys which contain /babel-plugin-module-resolver/ substring:

Plugin now has such shape:

Plugin {
  key: '/Volumes/npm_ram_disk/node_modules/babel-plugin-module-resolver/lib/index.js',
  manipulateOptions: undefined,
  post: undefined,
  pre: [Function: pre],
  visitor:
   { Program: { enter: [Object] },
     _exploded: true,
     _verified: true } }

Tested locally - worked perfectly. This PR backward compatible with babel 6.

`memoisedPlugins` does not exists in Babel 7.0.0 
So I'm traversing plugins by its keys which contain `/babel-plugin-module-resolver/` substring:

Plugin now has such shape: 
```js
Plugin {
  key: '/Volumes/npm_ram_disk/node_modules/babel-plugin-module-resolver/lib/index.js',
  manipulateOptions: undefined,
  post: undefined,
  pre: [Function: pre],
  visitor:
   { Program: { enter: [Object] },
     _exploded: true,
     _verified: true } }
```
@tleunen
Copy link
Owner

tleunen commented Jul 18, 2017

Thank you @nodkz. I'm so sorry for the delay, I'll try to take a look later today.

Because Babel 7 is not the latest stable version yet, I'd like to have the tests running with both babel 6 and babel 7 to make sure everything is correct.

@nodkz
Copy link
Contributor Author

nodkz commented Jul 18, 2017

I'm absolutely zero in circle.ci. So I dont know how to setup it for multi-env. And suppose that I will not have enought rights to do it.

When you will review, take a look that my PR does not break any old code/behaviour and can be safely merged without tests.

@tleunen
Copy link
Owner

tleunen commented Jul 18, 2017

Sure, np 😉

@codecov
Copy link

codecov bot commented Jul 18, 2017

Codecov Report

Merging #63 into master will decrease coverage by 5.76%.
The diff coverage is 25%.

Impacted Files Coverage Δ
src/index.js 94.23% <25%> (-5.77%) ⬇️

@nodkz
Copy link
Contributor Author

nodkz commented Sep 30, 2017

Any progress?

@tleunen
Copy link
Owner

tleunen commented Oct 4, 2017

@nodkz I'm sorry. I took a long break from OSS for a while. I'll try to catch up with new PR and tickets in the next few days with the upgrade to Babel 7 and the release of the new version

@tleunen tleunen merged commit 1ffa7f5 into tleunen:master Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants