Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

chore: Update babel-plugin-module-resolver peerdep to allow v4 #108

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

nappy
Copy link
Contributor

@nappy nappy commented Dec 16, 2019

Since babel-plugin-module-resolver v4 is released, the peer dependency should be updated accordingly.
Please review, whether ^3.0.0 should be "or"ed too, and whether there are any compatibility issues. I have not noticed any so far, and the diff between 3 and 4 is also very minor.

Since babel-plugin-module-resolver v4 is released, the peer dependency should be updated accordingly.
Please review, whether ^3.0.0 should be "or"ed too, and whether there are any compatibility issues. I have not noticed any so far, and the diff between 3 and 4 is also very minor.
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

@tleunen
Copy link
Owner

tleunen commented Dec 16, 2019

You're right, the only "breaking change" is the fact that we officially dropped Node 6. Most users shouldn't be affected by this.

Thanks for the PR, I'll keep it open for now as I'd like to upgrade all of the other dependencies as well at the same time before releasing a new version here

@nappy
Copy link
Contributor Author

nappy commented Jan 6, 2020

I understand that you want to upgrade other dependencies instead of merging just this PR, but I think it should be done rather sooner than later. The current situation is, that you get an error/unmet peer dependency when using both packages at their latest version. The other dependencies are automatically resolved by npm. Unmet peer dependencies, however need to be fixed manually.

@tleunen
Copy link
Owner

tleunen commented Jan 6, 2020

Yup, agreed. Sorry. Could you please update the range to allow v3 and v4?, and I'll merge it. Thanks!

Copy link
Owner

@tleunen tleunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nappy !

@tleunen tleunen changed the title Upgrade babel-plugin-module-resolver peer dependency to ^4.0.0 chore: Update babel-plugin-module-resolver peerdep to allow v4 Jan 7, 2020
@tleunen tleunen merged commit 57f7922 into tleunen:master Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants