Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Update plugin key name #75

Closed
wants to merge 1 commit into from
Closed

Update plugin key name #75

wants to merge 1 commit into from

Conversation

tleunen
Copy link
Owner

@tleunen tleunen commented Nov 8, 2017

Ref #74.

Need to investigate why the beta.2 works, but not the beta.31 (the latest)

@fatfisz
Copy link

fatfisz commented Nov 11, 2017

@tleunen Just to make sure: you meant beta.3?

I wandered in the wrong direction for a bit, but I think I understand what's happened now.

Basically the signature changed here: https://github.com/babel/babel/pull/6350/files#diff-5fbe3f3548c58af9b3a1edd90daf9035L12, and the change to the Plugin class itself can be seen here: https://github.com/babel/babel/pull/6350/files#diff-87e2d4f5f08732f1924207a97475a26c

Instead of an array of pairs (arrays) consisting of the plugin info and options, the options are integrated into the plugin info. I'll prepare a patch for that (and a bit of an extra 😉).

@fatfisz
Copy link

fatfisz commented Nov 11, 2017

I created another PR with the changes, as I couldn't modify this one.

@tleunen tleunen closed this Nov 20, 2017
@tleunen tleunen deleted the fix/babel7 branch November 20, 2017 03:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants