-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
Yikes, this isn't ready. I didn't realize that this totally breaks the |
Unfortunately, I fear there's no way to fix the |
So are we waiting for the updated types in @DefinitelyTyped before we can fix the issue here? Or would this be ok to merge, without full TS support, and then fix it once and for all when they got it fixed on their side? It seems this also has the fix for #11, can we move this in another PR so it's easier to follow what's needed for one fix and the other? |
It's probably best to merge this as-is (assuming this correctly fixes the build errors) and fix TS support once DT gets updated. This doesn't have the fix for #11; that's in 63b946e, which is in the |
Counterpoint: we can reject this PR and hope that DefinitelyTyped/DefinitelyTyped#13579 goes through. It looks like it's passed their PR checks so hopefully that should get pulled in the next day or so, which should make it easier to do some cleanup before merging fixes to #10 and #11 (and hopefully #12 not too long thereafter). |
Andy managed to merge v4.3.0 to DT after my failed attempts! |
Thanks @clark-stevenson! Fixing the types now so we can get this merged in. |
...more accurately, fixing this as soon as the DT bot updates the NPM module. 😃 |
Welp, scratch that. pixijs/pixi-typescript#133 never got merged in with the DT update so now we need to wait for that to get merged in as well. |
Now blocked on DefinitelyTyped/DefinitelyTyped#13631. |
I think this is finally ready! |
This PR fixes some TS errors that were in the previous version and switches from
@types/pixi.js
topixi-typescript
for the Pixi typings definition files, as the latter is generally kept more up-to-date. At some point we should hopefully be able to revert to@types/pixi.js
or remove the dependency altogether depending on how the folks atpixi-typescript
decide to handle definition management long-term.