Add CLI configuration flags. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a simple argparser object to confiure the geth exporter using the commandline. It overrides default values and settings in a yml file (if present), but only does so for explicitly stated config options. If the option is not passed, no overriding takes place and the usual yml>defaults order takes place.
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple argparser object to configure
the geth exporter using the commandline.
It overrides default values and settings in a
yml file (if present), but only does so for
explicitly stated config options. If the
option is not passed, no overriding takes
place and the usual yml>defaults order
takes place.
This is especially useful to us, since we tend
to run the exporter in docker, and mounting
a volume for a config file vs just passing the
config as cli flags to the container is simpler
for our deployment procedure.