Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a smaller LR? #4

Closed
152334H opened this issue Mar 14, 2023 · 6 comments
Closed

use a smaller LR? #4

152334H opened this issue Mar 14, 2023 · 6 comments

Comments

@152334H
Copy link

152334H commented Mar 14, 2023

The Karparthy Constant used currently might be too high? The loss for this training run is not going down after LR increases beyond ~1e-4:

image

@tloen
Copy link
Owner

tloen commented Mar 14, 2023

I've observed similar — updating to 2e-5 as in the original paper. I'll check in the morning if it works better.

@152334H
Copy link
Author

152334H commented Mar 14, 2023

image

this doesn't seem to actually help. Purple line is with 2e-5, green line 3e-4.

Maybe this is just the best result obtainable with the q_proj/v_proj parameters?

@tloen
Copy link
Owner

tloen commented Mar 14, 2023

Have you evaluated the model quality? I've always suspected that instruct-tuning is much less data-intensive than most people think.

@tloen
Copy link
Owner

tloen commented Mar 14, 2023

Could also be worth trying to disable the int8 quantization or increase the matrix rank. Will check tomorrow.

@kesar
Copy link

kesar commented Mar 15, 2023

Captura de pantalla 2023-03-15 a las 22 49 47

same here.

only changed:
BATCH_SIZE = 256
MICRO_BATCH_SIZE = 5

@tloen
Copy link
Owner

tloen commented Mar 16, 2023

Fwiw I've been able to eke out some small gains setting LORA_R to 8 instead of 4. Otherwise, seems (until proven otherwise) like both learning rates are perfectly fine.

@tloen tloen closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants