talk/groups: fixed dark mode favicons #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonfuz
force-pushed
the
dark-mode-favicons
branch
from
093f23d
to
fc47e24
Compare
|
Realized I forgot to remove an old unused fill option on one of the icons, did a fix and force pushed. Also tested the talk icon and took more comparison screenshots (adding to the original post) |
|
🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left - before, Right - after
Because we already use SVG favicons, I went with the simple solution of adding some CSS to the SVG files of the favicon.
You can read about this on https://joyofcode.xyz/dark-mode-favicon under the "Using a SVG Favicon" section.