welcome card: update style, copy, and behavior #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecananian
reviewed
Dec 18, 2023
ui/src/components/WelcomeCard.tsx
Outdated
| </p> | ||
| <p className="leading-5"> | ||
| Visit the{' '} | ||
| <span className="font-semibold dark:font-bold">Tlon Studio</span>{' '} |
There was a problem hiding this comment.
Might make sense to have Tlon Studio be a link?
There was a problem hiding this comment.
@alecananian during first time boots, this card will exist above the two pre-invited groups "Tlon Locals" and "Tlon Studio", so they'll technically be right where they need to be! That being said, I think it'd a good idea to duplicate the ability to jump to Tlon Studio in case curious people tap the bolded word.
urcades
requested changes
Dec 18, 2023
|
Added that affordance for any curious clickers :~) |
alecananian
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the welcome card up to date with the copy and styling in Figma. Adapts it to be shown on desktop views as well, positioned above the activity feed on the home screen.
Closed status is no longer stored locally on the frontend, instead its tracked in the settings agent. This means closing the card once will hide it on all clients.
Fixes LAND-1399