Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: fix gallery image view and delete button in list mode #3148

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

alecananian
Copy link
Collaborator

  • Fixes issue with gallery image thumbnails not loading in list view
  • Fixes issue with gallery item delete button not working in list view
Screen.Recording.2023-12-20.at.4.50.47.PM.mov

Copy link

linear bot commented Dec 21, 2023

Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines -67 to +61
const nest = useNest();
const chFlag = useChannelFlag();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm curious why this would be wrong, is there an issue with the nest hook?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's probably obsolete. It looks for an app router param, which I don't see defined in any routes.

@alecananian alecananian merged commit 417bda9 into develop Jan 8, 2024
1 check passed
@alecananian alecananian deleted the alec/land-1432-gallery-list-images branch January 8, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants