Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add character counter to group description editor #3161

Merged
merged 2 commits into from
Jan 2, 2024
Merged

add character counter to group description editor #3161

merged 2 commits into from
Jan 2, 2024

Conversation

alecananian
Copy link
Collaborator

Adds a character counter and error state to the group description editor

Screen.Recording.2024-01-01.at.11.14.30.PM.mov

@linear Linear
Copy link

linear bot commented Jan 2, 2024

LAND-1392 groups: appropriately warn when trying to save invalid group description

mrozanski
mrozanski suggested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@mrozanski mrozanski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works when creating new groups.
For some reason it doesn't register the error when editing an existing one.

Screenshot 2024-01-02 at 10 26 46 AM

@alecananian
Copy link
Collaborator Author

Good catch @mrozanski! I've updated the edit group form to use the same onChange validation strategy as the create group form

@alecananian alecananian merged commit b3d12e5 into develop Jan 2, 2024
1 check passed
@alecananian alecananian deleted the alec/land-1392-groups-desc branch January 2, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrozanski mrozanski mrozanski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alecananian @mrozanski