Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

talk: fix dropdown on multi-dms invite dialog #3164

Merged
merged 1 commit into from
Jan 8, 2024
Merged

talk: fix dropdown on multi-dms invite dialog #3164

merged 1 commit into from
Jan 8, 2024

Conversation

alecananian
Copy link
Collaborator

  • Fixes the dropdown getting cut off on the multi-party DMs invite dialog
  • Adds lint-staged to devDependencies because the pre-commit hook using npx was grabbing v15 by default, which is not compatible with Node v16
Screenshot 2024-01-08 at 9 19 44 AM

@linear Linear
Copy link

linear bot commented Jan 8, 2024

LAND-1431 multi-DMs: inviting another ship is impossible

arthyn
arthyn approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, probably time to update node

@arthyn arthyn merged commit 6a3b2c1 into develop Jan 8, 2024
1 check passed
@arthyn arthyn deleted the alec/land-1431-invite-multi-dms branch January 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthyn arthyn arthyn approved these changes

@latter-bolden latter-bolden Awaiting requested review from latter-bolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alecananian @arthyn