Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add route to support thread reacts #3177

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

alecananian
Copy link
Collaborator

Resolves LAND-1391
Resolves LAND-1460

Adds a new route to support showing the emoji picker on mobile when deep-linking to a specific message in a thread via activity tab/push notifications

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reacting to root thread messages was still failing for me, but pushed a small change to the picker logic that seems to fix it.

With that change, is working as expected.

@alecananian
Copy link
Collaborator Author

I am realizing now I very stupidly did not even tap on an emoji to test the sending of it 🙂 Thanks for the change!

@alecananian alecananian merged commit 108bfae into develop Jan 16, 2024
1 check passed
@alecananian alecananian deleted the alec/land-1391-thread-react branch January 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants