LAND-1058: Fetch new post authors as contacts #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midsum-salrux
force-pushed
the
ns/fetch-contact-on-new-message
branch
from
185540b
to
752244c
Compare
|
@midsum-salrux yeah %heed is idempotent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/tlon/issue/LAND-1058/contacts-on-fetch-of-posts-collect-new-authors-to-register-as-contact
This doesn't check whether we're adding someone we already have as a contact. I think that it's better for %contacts to make that idempotent than checking it here, which it looks it does but I'm not 100%.