Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: fetching tweaks #3186

Merged
merged 5 commits into from
Jan 19, 2024
Merged

groups: fetching tweaks #3186

merged 5 commits into from
Jan 19, 2024

Conversation

latter-bolden
Copy link
Member

Handles a few improvements for fetching posts:

  • avoids incomplete message history when navigating to a channel by only adding new messages to the cache if we've already fetched the query
  • on boot, any cached post queries with unreads get refetched so new messages are immediately available upon navigating to the channel
  • bumps page size to 100 in the app and 300 on desktop to prevent extra fetching on scroll and allow fewer requests on refetch

We should monitor performance after this lands on our ships. Particularly for any of us with lots of groups that are used frequently. We may need to restrict on boot cache updates to pinned groups for now if it proves too expensive.

Fixes LAND-1473
Fixes LAND-1474

Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@latter-bolden latter-bolden merged commit 861061a into develop Jan 19, 2024
1 check passed
@latter-bolden latter-bolden deleted the lb/fetching-fixes branch January 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants