various: remove old/stale/unused dependencies #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove all references to and dependencies on graph-store, metadata-store, group-store, and versions of channel types older than the previous generation. This does mean that we remove migration/import logic for versions of groups preceding the previous one, but the migration path coming from that far back was already known to need some manual guidance. Notably inclusion is a bugfix in /app/notify: it was still scrying into %group-store, when it should have been updated to scry into %groups instead.
This sort of suggests it's stale...
/sur/hark-store no longer exists, here or in tloncorp/landscape. The type used here also doesn't nest inside of the type used by current %hark. This suggests the code here is stale, but for now we simply make it compile in the absence of the desired dependency.
|
Both the groups and talk desks can now be constructed from the following copy operations: cp -RL urbit/pkg/base-dev/* ship/desk/
cp -RL landscape/desk-dev/* ship/desk/
cp -RL landscape-apps/desk/* ship/desk/(Replacing Neither of them need all the files that the dev desks provide, but given we don't have a way of specifying/copying the exact subset we need, we just stay with the status quo of "superfluous inclusions" for now. We should, when we next deploy, probably do a full mounted desk wipe + the above copy operation, to make sure we're at least not leaving any of the now-removed files in place. Perhaps CI's deploy logic already takes care of this? |
An artifact of times long past?
Rather than through the file containing the latest types.
It was deemed Good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove all references to and dependencies on graph-store, metadata-store, group-store, and versions of channel types older than the previous generation.
This does mean that we remove migration/import logic for versions of groups preceding the previous one, but the migration path coming from that far back was already known to need some manual guidance.
Notably inclusion is a bugfix in /app/notify: it was still scrying into %group-store, when it should have been updated to scry into %groups instead. PTAL.
Marking as draft for now, because:
Fixes LAND-1243.