Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: backwards compat for scries and use proper scry paths #3191

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jan 24, 2024

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

This fixes an issue where scries were failing after the recent flagging PR #3168 in going to fix I realized we broke our versioning scheme. So, this implements backwards compatibility for the v0 scries and adds new scries for latest version v1. Also noticed we're missing some marks in the mark warmer.

To test I opened the app from an old frontend that still used v0 scries and everything was working, then loaded the new frontend with v1 paths and everything was still working.

Copy link
Collaborator

@midsum-salrux midsum-salrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

desk/app/groups.hoon Outdated Show resolved Hide resolved
@arthyn arthyn merged commit 1254bc5 into develop Jan 24, 2024
1 check passed
@arthyn arthyn deleted the hm/better-flagging-scry-handling branch January 24, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants