chat: prevent gap in message history when viewing scrollback #3198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new message comes in while you're viewing a scroll-back (search or message ref clicked), it will be added to the cache directly after the loaded message history. This can lead to a weird gap between new messages and the point in the history you were viewing. An automated refetch is fired which resolves the situation, but it can take a bit depending on network conditions leaving you in a weird state until the refetch completes.
This prevents that scenario by checking to see if you have the newest messages before adding incoming ones to the cache.
Fixes LAND-1478
PR Checklist