Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag & drop: fix dragging Mac screenshots into galleries #3203

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Jan 26, 2024

This seems to just have been an issue with spaces in the filename as expected. Uploading screenshots on Mac should now work in Safari.

While testing this, I noticed a regression with the drag & drop fix from the other day as well. There's a long outstanding bug with handling a key dragleave event property in Safari which was causing the drag hover state to flicker or fail. This PR also smuggles in a way to combat that while leaving in place the fix for other browsers.

Worked locally against a self-hosted ship in Safari & Chrome. Whoever tests this, please verify drag & drop works in both gallery and chat contexts on both browsers.

Fixes LAND-1446

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@latter-bolden
Copy link
Member Author

Note: this will need to be included in the next release since this patches the other D&D fix which is already on staging.

Copy link

linear bot commented Jan 26, 2024

Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@arthyn arthyn changed the base branch from develop to staging January 29, 2024 19:29
@arthyn
Copy link
Member

arthyn commented Jan 29, 2024

@latter-bolden you might have to rebase if we're going to point at staging

@latter-bolden
Copy link
Member Author

Yep, should be in sync with staging now.

Was also confirming multiple drop zones works as expected, behavior seems to be in line with livenet 👍

@arthyn
Copy link
Member

arthyn commented Jan 29, 2024

@mrozanski going to deploy this to binnec since this fixes an issue introduced by one of the earlier drag fixes.

@arthyn arthyn merged commit adc918c into staging Jan 29, 2024
1 check passed
@arthyn arthyn deleted the lb/screenshot-fix branch January 29, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants