Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tlon desktop: move Talk functionality into main app + sidebar updates #3207

Merged
merged 23 commits into from
Feb 6, 2024

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Jan 31, 2024

Adds the ability to access the core Talk sidebar from within the main app on desktop. Overhauls the way the Sidebar looks, adds Search for group/message lists, adds flow for desktop DM creation, etc.
Tested locally against self & hosted ships.

Fixes LAND-1513
Fixes LAND-1522

Copy link

linear bot commented Jan 31, 2024

@latter-bolden latter-bolden marked this pull request as ready for review February 2, 2024 16:15
@arthyn arthyn self-requested a review February 2, 2024 17:29
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a few suggestions/comments

ui/src/components/Sidebar/useSearchFilter.ts Outdated Show resolved Hide resolved
ui/src/components/Sidebar/useSearchFilter.ts Show resolved Hide resolved
ui/src/components/Sidebar/MessagesSidebar.tsx Outdated Show resolved Hide resolved
latter-bolden and others added 3 commits February 2, 2024 16:40
Co-authored-by: Hunter Miller <hunter@hmiller.dev>
This does not pull out Talk code, but it lays the groundwork by moving
messaging into the core app and displays a sunset message. This should
be the last update to Talk, hereafter we should avoid using Talk deploy
hooks to avoid breaking its components & routing.'

https://www.youtube.com/watch?v=Q3Kvu6Kgp88
Copy link

linear bot commented Feb 3, 2024

@mrozanski
Copy link
Contributor

Found while testing this branch:

Desktop, Groups, chat, Clicking on a sigil of a message's author
Expected:
stay in the same browser tab/window, open DM UI in the Messages app nav section
For example: https://localhost:3000/apps/groups/dm/~nocsyx-lassul
Observed:
New browser tab pointing to https://localhost:3000/apps/talk/dm/~nocsyx-lassul

Note: Desktop browser in small (mobile) size does the same.
Haven't tested from the mobile app.

@mrozanski
Copy link
Contributor

I’ve noticed that when I click on an item in Activity that opens a group chat, if then I click the back arrow at the top of the side nav, I’m taken to the Groups home with no contents in the main pane. I would expect to go back to Activity instead.

On mobile and if the activity belongs to a thread this is more noticeable because clicking on < sends me to the main thread of that channel, then to the group home, and then to groups.
The behavior is probably designed like this and it would make sense that I can navigate back that way in other circumstances. But when coming from the activity list, I personally prefer to go back to that list in one step, as I’d most likely be catching up with activity in general.

@mrozanski
Copy link
Contributor

I assume it is expected (found the same in Figma) but noting that the Groups icon is now a house instead of the one currently being used.
group-icon

@mrozanski
Copy link
Contributor

Messages > Filter icon next to Direct Messages (drop down)
"Group Talk Channels" doesn't sound right.

grouptalk

Maybe "Group channels"?

@mrozanski
Copy link
Contributor

Member links in Chat info point to talk URL

Opening a multi-DM, clicking on the three dots at the top > Chat info

multi-dm-info

Copy link
Contributor

@mrozanski mrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments verified.
Approving.

@latter-bolden latter-bolden merged commit fb91a6b into develop Feb 6, 2024
1 check passed
@latter-bolden latter-bolden deleted the lb/nav-overhaul branch February 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants