-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tlon desktop: move Talk functionality into main app + sidebar updates #3207
Conversation
…omponent interfaces where referenced elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, a few suggestions/comments
Co-authored-by: Hunter Miller <hunter@hmiller.dev>
This does not pull out Talk code, but it lays the groundwork by moving messaging into the core app and displays a sunset message. This should be the last update to Talk, hereafter we should avoid using Talk deploy hooks to avoid breaking its components & routing.' https://www.youtube.com/watch?v=Q3Kvu6Kgp88
Found while testing this branch: Desktop, Groups, chat, Clicking on a sigil of a message's author Note: Desktop browser in small (mobile) size does the same. |
I’ve noticed that when I click on an item in Activity that opens a group chat, if then I click the back arrow at the top of the side nav, I’m taken to the Groups home with no contents in the main pane. I would expect to go back to Activity instead. On mobile and if the activity belongs to a thread this is more noticeable because clicking on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments verified.
Approving.
Adds the ability to access the core Talk sidebar from within the main app on desktop. Overhauls the way the Sidebar looks, adds Search for group/message lists, adds flow for desktop DM creation, etc.
Tested locally against self & hosted ships.
Fixes LAND-1513
Fixes LAND-1522