Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: removing Talk #3208

Merged
merged 20 commits into from
Feb 8, 2024
Merged

app: removing Talk #3208

merged 20 commits into from
Feb 8, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Feb 1, 2024

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

This fixes LAND-1521 removing Talk and all associated code. It also removes the wayfinding button and moves the privacy notice and help and support options into the main app menu.

@arthyn
Copy link
Member Author

arthyn commented Feb 2, 2024

Targeting Brian's branch, but this should be merged to develop only after his branch goes to staging. This will ensure that people can get the deprecation message deployed to Talk first and then it will receive no other deploys.

Copy link

linear bot commented Feb 2, 2024

@arthyn arthyn changed the title (WIP) app: removing Talk app: removing Talk Feb 2, 2024
@arthyn arthyn marked this pull request as ready for review February 2, 2024 23:30
Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want another set of eyes on the hoon changes, but this is looking good to me sans conflicts. Couple of very minor notes

ui/src/dms/MobileMessagesSidebar.tsx Outdated Show resolved Hide resolved
desk/app/chat.hoon Outdated Show resolved Hide resolved
desk/app/chat.hoon Outdated Show resolved Hide resolved
Base automatically changed from lb/nav-overhaul to develop February 6, 2024 17:18
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor changes to copy and I feel like we ought to not no-op on analytics for the native app, that doesn't make much sense.

ui/src/components/Settings/Settings.tsx Outdated Show resolved Hide resolved
ui/src/components/Settings/Settings.tsx Outdated Show resolved Hide resolved
ui/src/components/Settings/Settings.tsx Outdated Show resolved Hide resolved
ui/src/logic/analytics.ts Outdated Show resolved Hide resolved
ui/src/state/settings.ts Outdated Show resolved Hide resolved
arthyn and others added 3 commits February 6, 2024 17:50
Co-authored-by: Patrick O'Sullivan  <patrick@osullivan.io>
Co-authored-by: Patrick O'Sullivan  <patrick@osullivan.io>
Co-authored-by: Patrick O'Sullivan  <patrick@osullivan.io>
@arthyn arthyn merged commit 8b68ab7 into develop Feb 8, 2024
1 check passed
@arthyn arthyn deleted the hm/talk-rip-out branch February 8, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants