-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: removing Talk #3208
app: removing Talk #3208
Conversation
Targeting Brian's branch, but this should be merged to develop only after his branch goes to staging. This will ensure that people can get the deprecation message deployed to Talk first and then it will receive no other deploys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want another set of eyes on the hoon changes, but this is looking good to me sans conflicts. Couple of very minor notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor changes to copy and I feel like we ought to not no-op on analytics for the native app, that doesn't make much sense.
Co-authored-by: Patrick O'Sullivan <patrick@osullivan.io>
Co-authored-by: Patrick O'Sullivan <patrick@osullivan.io>
Co-authored-by: Patrick O'Sullivan <patrick@osullivan.io>
PR Checklist
This fixes LAND-1521 removing Talk and all associated code. It also removes the wayfinding button and moves the privacy notice and help and support options into the main app menu.