channels: fix kick/resubscribe loop caused by flagging #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthyn
commented
Feb 1, 2024
desk/app/channels.hoon
Outdated
| @@ -575,6 +575,7 @@ | |||
| == | |||
| ++ ca-abed | |||
| |= n=nest:c | |||
| ?. (~(has by v-channels) n) ca-core | |||
There was a problem hiding this comment.
@Fang- @midsum-salrux I don't think this is actually good and could end up doing weird things. I tried moving up to line 541 and doing some no-oping there but I'm not sure that's right either.
There was a problem hiding this comment.
Yeah this changes the semantics of +ca-abed enough to make a lot of the code here "clearly wrong".
Was gonna say that, what we want instead, is a %u scry for channel existence, but we already have it! Whoever is doing a scry that fails on the got:by here should first be doing the %u version of the scry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This fixes LAND-1528 which was causing a kick/resubscribe loop because our scry caused a crash. This changes the scry so that it no-ops if it doesn't find the content and also changes the
ca-abedpath to no-op if a channel is not found.