%activity agent #3219
Merged
%activity agent #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also implement logic for finding the "floor", timestamp of oldest unread activity, for a certain category (everything, or a specific thread). (The reader should also note that the struggle with "time id" types continues...)
midsum-salrux
force-pushed
the
ns/activity-agent
branch
from
5e9c2a1
to
7f17b6f
Compare
arthyn
reviewed
Feb 26, 2024
arthyn
reviewed
Feb 27, 2024
desk/sur/activity.hoon
Outdated
| [%club p=id:club] | ||
| [%club p=@uvH] | ||
| == | ||
| +$ timid time |
arthyn
reviewed
Feb 27, 2024
desk/app/activity.hoon
Outdated
| ^- (unit (unit cage)) | ||
| ?+ pole [~ ~] | ||
| [%x ~] | ||
| ``activity-full+!>([stream indices]) |
There was a problem hiding this comment.
Would maybe add unreads summary to this
arthyn
reviewed
Feb 27, 2024
desk/desk.bill
Outdated
| @@ -7,5 +7,6 @@ | |||
| %groups-ui | |||
| %channels | |||
| %channels-server | |||
| %activity | |||
There was a problem hiding this comment.
I think we should probably leave it out and turn it on manually until we're ready for it to run in production. This won't be released for a while but it would be nice to let it flow through the release pipeline, but not be on by default.
arthyn
reviewed
Feb 28, 2024
desk/sur/activity.hoon
Outdated
Comment on lines
4
to
6
| ++ eon ((on time event) lte) | ||
| ++ emp ((mp time event) lte) | ||
| ++ mep ((on time event-parent) lte) |
There was a problem hiding this comment.
we might need clearer names here
|
overall this looks good, I think we can address some of the comments here and get a test thread then move on to integrating it, because that's where will find real issues. |
arthyn
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist