Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

talk sunset: correctly register if you've already seen the sunset banner & add passive indicator on mobile #3221

Merged
merged 2 commits into from
Feb 8, 2024
Merged

talk sunset: correctly register if you've already seen the sunset banner & add passive indicator on mobile #3221

merged 2 commits into from
Feb 8, 2024

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Feb 8, 2024 •
edited

OTT

Tested locally against hosted ship.

Fixes LAND-1541

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@linear Linear
Copy link

linear bot commented Feb 8, 2024

LAND-1541 talk sunset: fix marking sunset banner as seen & allow manual display on mobile

patosullivan
patosullivan approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@arthyn arthyn merged commit 5e0a5f1 into staging Feb 8, 2024
1 check passed
@arthyn arthyn deleted the lb/fix-talk-sunset branch February 8, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patosullivan patosullivan patosullivan approved these changes

@arthyn arthyn Awaiting requested review from arthyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@latter-bolden @patosullivan @arthyn