Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: fix inconsistencies from previous talk/groups split #3222

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Feb 8, 2024

Fixes title so it no longer says "undefined", makes sure you can see all activity, and adjusts some copy that was confusing. Tested by opening app locally and looking at title bar, activity indicator, and notifications screen.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthyn arthyn merged commit 222f3eb into staging Feb 8, 2024
1 check passed
@arthyn arthyn deleted the hm/fix-title-in-channels branch February 8, 2024 22:02
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@patosullivan
Copy link
Member

Oh this was already merged, ha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants