Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop nav: display unread count on messages tab #3223

Merged
merged 4 commits into from
Feb 8, 2024
Merged

desktop nav: display unread count on messages tab #3223

merged 4 commits into from
Feb 8, 2024

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Feb 8, 2024 •
edited

Accounts for what your messages sidebar filter is. Displays number of unread channels/DMs, not total message count.

Screenshot 2024-02-08 at 5 34 24 PM

Tested locally against a hosted ship.

Fixes LAND-1417

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

arthyn
arthyn approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@linear Linear
Copy link

linear bot commented Feb 8, 2024

LAND-1417 unreads: unread DMs count not displayed in Talk title bar

@tloncorp tloncorp deleted a comment from linear bot Feb 8, 2024
@latter-bolden latter-bolden merged commit c342622 into staging Feb 8, 2024
1 check passed
@latter-bolden latter-bolden deleted the lb/messages-tab-count branch February 8, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthyn arthyn arthyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@latter-bolden @arthyn