Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: eliminate discover/find interface #3233

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

jamesacklin
Copy link
Member

@jamesacklin jamesacklin commented Feb 9, 2024

Removes the "Find Groups" or "Discover" tab from the mobile navbar and the desktop sidebar. This also removes the empty-state notices that point the user to said "Discover" tab or "Find Groups" page.

Tested locally with a moon in zero groups and locally with a planet in >50 groups.

The below screenshots show a new, self-hosted moon (the absolute base case). A new hosted planet will be joined to Tlon Studio and Tlon Local; the green banner will still be present.

Screenshot 2024-02-09 at 1 25 24 PM

Screenshot 2024-02-09 at 1 25 07 PM

Fixes LAND-1197

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Copy link

linear bot commented Feb 9, 2024

Copy link
Member

@urcades urcades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested locally with fresh comet.

@arthyn arthyn merged commit 5996c66 into develop Feb 9, 2024
1 check passed
@arthyn arthyn deleted the james/land-1197-groups-discovery-joining-overhaul branch February 9, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants