Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop sidebar: fix double scrollbar and persist nav location when tab switching #3240

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

latter-bolden
Copy link
Member

Moves search up into the top section of the sidebar to avoid double scroller after adjusting the viewport. Also adds logic to save the navigation state for the groups and messages tabs so you can pick up where you left off when returning to the tab.

Right now this is only enabled for messages since it's unclear how this should work for groups given the current in-group sidebar transition and back behavior. It's a one line change to add it to groups as well if we figure out a way to go that route.

Fixes LAND-1553
Fixes LAND-1554

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, saving the nav state will be nice.

@latter-bolden latter-bolden merged commit 3e9ab4d into staging Feb 13, 2024
1 check passed
@latter-bolden latter-bolden deleted the lb/sidebar-nav-state branch February 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants