Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAND-1568: Add contact on new post fix #3252

Merged
merged 1 commit into from
Feb 15, 2024
Merged

LAND-1568: Add contact on new post fix #3252

merged 1 commit into from
Feb 15, 2024

Conversation

midsum-salrux
Copy link
Collaborator

@midsum-salrux midsum-salrux commented Feb 15, 2024 •
edited

PR Checklist

  • Includes changes to desk files
    app/channels.hoon
  • Describes how you tested the PR locally (test ship vs livenet)
    Livenet moons
  • If a new feature, includes automated tests
    N/A
  • Comments added anywhere logic may be confusing without context
    N/A

@linear Linear
Copy link

linear bot commented Feb 15, 2024

LAND-1568 contacts: not loading in automatically

arthyn
arthyn approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested locally, let's actually put this on staging

@arthyn arthyn changed the base branch from develop to staging February 15, 2024 20:22
@arthyn arthyn changed the base branch from staging to develop February 15, 2024 20:22
@arthyn
Copy link
Member

arthyn commented Feb 15, 2024

nvm let's just do develop

@arthyn arthyn merged commit 38323f0 into develop Feb 15, 2024
1 check passed
@arthyn arthyn deleted the ns/contacts-on-join-fix branch February 15, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthyn arthyn arthyn approved these changes

@Fang- Fang- Awaiting requested review from Fang-

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@midsum-salrux @arthyn