Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some monorepo issues #3254

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

patosullivan
Copy link
Member

  • adds the build step back in for the shared package. we're going to want npm run dev in there so we can update files in there while working in dev on either app, afaict. updates gh workflows appropriately.
  • fixes the import sort order issue. prettier rc had been updated to use @trivago/prettier-plugin-sort-imports and wasn't configured with our @/ root alias in mind. This made eslint mad every time you opened a file.

@alecananian
Copy link
Collaborator

Thanks! tsup.config.ts got removed in a merge: https://github.com/tloncorp/landscape-apps/blob/b3700b9f00da58ee358131487721f68bbe27c06f/packages/shared/tsup.config.ts
But the inline options on the build command achieve the same thing - looks good 👍

@patosullivan patosullivan merged commit 0773cb1 into develop Feb 16, 2024
@patosullivan patosullivan deleted the po/fix-some-monorepo-issues branch February 16, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants