Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: add tamagui #3255

Merged
merged 3 commits into from
Feb 20, 2024
Merged

native: add tamagui #3255

merged 3 commits into from
Feb 20, 2024

Conversation

dnbrwstr
Copy link
Collaborator

This PR performs initial setup of tamagui in the native mobile app. Tamagui components are kept in a separate package (ui) to help keep it encapsulated, since the longer term goal is to use it in both the web and native apps.

How to test:

  • Build the mobile app
  • Try using Button from @tloncorp/ui

@dnbrwstr
Copy link
Collaborator Author

Converting to draft while I resolve the type error, which weirdly didn't show up in VSCode.

@alecananian alecananian mentioned this pull request Feb 19, 2024
4 tasks
@dnbrwstr
Copy link
Collaborator Author

Ok, should be good.

@dnbrwstr dnbrwstr marked this pull request as ready for review February 19, 2024 23:57
Copy link
Collaborator

@alecananian alecananian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My main concern was that the package/module methodology wouldn't work with hot reloading, but I tested it out locally and it's working as expected 👍

@dnbrwstr dnbrwstr merged commit e1b9bf1 into develop Feb 20, 2024
1 check passed
@dnbrwstr dnbrwstr deleted the db/add-tamagui branch February 20, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants