Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: add new preview profile for building apps with separate bundle ID #3257

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

alecananian
Copy link
Collaborator

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Changes

  • Configures Android to have preview and production product flavors with differing app icons and names
  • Configures iOS to have Landscape-preview and Landscape app targets with differing app icons and names
  • Updates Expo/EAS configs to support preview and production profiles
  • Updates CI workflows to allow user to choose profile while triggering jobs
  • Disables the push notification permission prompt for now in this repo so it doesn't conflict with the existing version of tlon-mobile on testers' devices

Unfortunately, I had to change the engines value in package.json because Expo's build servers don't support Node v20 yet. I set the Node engine as >=18.18.0 so we can continue using v20 locally and in other build processes.

Tested by running the eas build commands locally. New bundles are available in Google Play and Apple App Store already.

Copy link

linear bot commented Feb 17, 2024

@patosullivan
Copy link
Member

Hey, could we include the latest changes from tlon-mobile (notifications linking fix) on here too?

@mrozanski
Copy link
Contributor

Hey, could we include the latest changes from tlon-mobile (notifications linking fix) on here too?

We can, although since we still need to add push notifications to this version and we're not planning to use this one for production releases yet, I think it's OK to add the latest from tlon-mobile in a separate PR.

@mrozanski
Copy link
Contributor

Tracking @patosullivan 's suggestion (syncing changes from the other repo) in Linear. Thanks for surfacing.

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alecananian alecananian merged commit 008e91c into develop Feb 20, 2024
1 check passed
@alecananian alecananian deleted the alec/land-1551-set-up-mobile-build-pipeline branch February 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants