Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat: don't throw on unhandled message types #3259

Merged
merged 2 commits into from
Feb 20, 2024
Merged

chat: don't throw on unhandled message types #3259

merged 2 commits into from
Feb 20, 2024

Conversation

patosullivan
Copy link
Member

tested locally on a livenet moon.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@patosullivan patosullivan changed the title chat: don't throw on unhandled message types, return null instead (for now) chat: don't throw on unhandled message types Feb 20, 2024
@patosullivan
Copy link
Member Author

Fixes LAND-1582

arthyn
arthyn approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthyn arthyn merged commit 13e5b17 into develop Feb 20, 2024
1 check passed
@arthyn arthyn deleted the po/dont-throw-on-unhandled-message-types branch February 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthyn arthyn arthyn approved these changes

@latter-bolden latter-bolden Awaiting requested review from latter-bolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@patosullivan @arthyn