Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add npm run build:shared to postinstall on root package #3262

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

patosullivan
Copy link
Member

Without this you could run into eslint/ts errors on importing the package (until you manually build the package or run the dev script for it).

Copy link
Collaborator

@alecananian alecananian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! My only note is to now remove the build step from any CI workflows where we're already installing dependencies, otherwise it will be built twice.

@patosullivan
Copy link
Member Author

Makes sense! My only note is to now remove the build step from any CI workflows where we're already installing dependencies, otherwise it will be built twice.

good point! just removed them.

@patosullivan patosullivan merged commit 8757a55 into develop Feb 20, 2024
1 check passed
@patosullivan patosullivan deleted the po/add-shared-build-step-to-post-install branch February 20, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants