Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Don't focus ChatInput for /dm/groups/... routes #3263

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mrozanski
Copy link
Contributor

Since the nav bars of groups and talk were combined, when viewing a Group Chat using the Messages tab on desktop, the ChatChannel view does't recognize the search route if the Search button is clicked. In this case, the URL has a "/dm/groups" portion (instead of "/groups" as when in the Groups nav tab). Chat input should not be focused in those cases to allow the search input to be used.

Fixes LAND-1577

Tested locally with livenet ship

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Since the nav bars of groups and talk were combined, when viewing a Group Chat using the Messages tab on desktop, the ChatChannel view does't recognize the search route if  the Search button is clicked.
In this case, the URL has a "/dm/groups" portion (instead of "/groups" as when in the Groups nav tab).
Chat input should not be focused in those cases to allow the search input to be used.
Copy link

linear bot commented Feb 20, 2024

@mrozanski mrozanski merged commit fcb49ac into develop Feb 21, 2024
1 check passed
@mrozanski mrozanski deleted the search-focus branch February 21, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants