Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tamagui icons #3265

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add tamagui icons #3265

merged 3 commits into from
Feb 21, 2024

Conversation

dnbrwstr
Copy link
Collaborator

This PR adds a tamagui Icon component, styled according to latest designs. aCurrently it's only used by the tab nav component.

@dnbrwstr dnbrwstr changed the title Add tamagui icons. Add tamagui icons Feb 20, 2024
@alecananian
Copy link
Collaborator

Nice! Do we still need the react-native-svg package and all its associated files in the tlon-mobile app code?

@dnbrwstr
Copy link
Collaborator Author

We do still need react-native-svg, since the mobile package is does the actual bundling + rendering of the svg files, but you're right that we don't need the icons or .svgrrc -- I'll remove those. I think it does make sense to keep the svg.d.ts since the typing there will be slightly different than in the web context.

@dnbrwstr dnbrwstr merged commit 58890d1 into develop Feb 21, 2024
1 check passed
@dnbrwstr dnbrwstr deleted the db/add-tamagui-icons branch February 21, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants