channels: make sure channel data is up to date when we have unreads #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LAND-1556. getQueryData was always returning undefined in my testing locally, so rather than only refetching if we have cached data for a query, we just fetch the query if we have an unread for the channel (since we know we *will* use that data later). I also noticed that channelKey in state/channel/keys.ts was using 'channel' rather than 'channels'. 'channel' isn't used as a queryKey anywhere afaict, I assumed this was supposed to be 'channels', so I changed that.
patosullivan
changed the title
|
Just realized this won't work for dms/clubs too. Will reopen when it does. |
Similar changes to commit 91e281d, but for dms/clubs.
|
Ok, now works for dms/clubs too. |
latter-bolden
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Code makes sense and looks good.
I am seeing getQueryData fire correctly for cached channels with unreads, not sure where the mixup is there. The only reason we didn't go this route originally was performance concerns with fetching all unread channels every time you open the app.
That said, I do think this approach is cleaner and should help with the referenced Linear issue. We should just make sure to monitor UX after it's merged, particularly with power users who may have lots of groups they don't always check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LAND-1556.
getQueryData was always returning undefined in my testing locally, so rather than only refetching if we have cached data for a query, we just fetch the query if we have an unread for the channel (since we know we will use that data later).
I also noticed that channelKey in state/channel/keys.ts was using 'channel' rather than 'channels'. 'channel' isn't used as a queryKey anywhere afaict, I assumed this was supposed to be 'channels', so I changed that.
Tested locally with livenet moons.
PR Checklist