Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3: prevent attempt to upload to insecure s3 endpoint from secure context #3272

Merged
merged 1 commit into from
Feb 21, 2024
Merged

s3: prevent attempt to upload to insecure s3 endpoint from secure context #3272

merged 1 commit into from
Feb 21, 2024

Conversation

patosullivan
Copy link
Member

Fixes LAND-1592

tested locally on dev moon.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@linear Linear
Copy link

linear bot commented Feb 21, 2024

LAND-1592 s3: cannot upload files to http:// bucket when using ui from https://

latter-bolden
latter-bolden approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@latter-bolden latter-bolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm!

@patosullivan patosullivan merged commit bda99d9 into develop Feb 21, 2024
1 check passed
@patosullivan patosullivan deleted the po/land-1592-prevent-attempt-to-upload-to-unsecure-s3-from-secure-context branch February 21, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latter-bolden latter-bolden latter-bolden approved these changes

@arthyn arthyn Awaiting requested review from arthyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@patosullivan @latter-bolden