Move types to shared package. #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnbrwstr
requested review from
alecananian,
arthyn,
mrozanski and
latter-bolden
dnbrwstr
force-pushed
the
db/move-types
branch
from
419b85f
to
2cfb265
Compare
|
Fixed a different CI error, now only the one I'm ignoring is left. |
alecananian
reviewed
Feb 23, 2024
|
Fixed the cycle error -- turned out to be the product of a misplaced error suppression. Will bring up the eslint config in standup. |
alecananian
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Tested by building webapp.
This PR moves Urbit server-side types to the shared package. The import path is more complex than would be ideal, but I wasn't able to find a cleaner way to pull in the modules without making larger changes. I looked into using a
.tsconfigalias, but that only works for relative paths, not modules. Open to better solutions here!There's a failing pre-commit check here related to a module cycle. I didn't fix it because I believe it's a
lint-stagedthing -- only popping up because I touched a file that already had that issue, not because these changes created the issue.