-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile: generate profile tab icon from user sigil #3281
Conversation
This looks great! What do you think about moving the sigil wrapper to the shared ui lib? Seems like a pretty core component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments on styling consistency.
Although re-reading the above, maybe you're just wanting to hold off on styling w Tamagui until we build out a bit more -- fine with me if that's the case. |
For this, do you think we should move the memoized XML to the shared lib? The full component probably doesn't make sense because it's React Native-specific.
That was my initial thinking, but lemme dig into the Tamagui side a little today and see what I can do here 🙂 |
Ultimately, the goal is for the That's a secondary goal though, so feel free to ignore if it's laborious.
Cool :) |
Changed to approve since I don't think either of these are blockers. |
@dnbrwstr I've updated this to use Tamagui now |
Great, this looks good! I'm going to go ahead and merge. |
PR Checklist
Changes
Note: very simple implementation for now that doesn't have all the different sizing and color options we'll need. We can address the sizing when we start to use the sigil component on other tabs, and the colors when we get contacts syncing hooked up.