upload: handle no publicUrlBase #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patosullivan
deleted the
james/land-1615-groups-attaching-an-image-fails-with-self-hosted-s3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a TypeError in upload.ts when uploading to a S3 bucket without a publicUrlBase set in the %storage config.
Uploading an image was throwing a
Uncaught (in promise) TypeError: Failed to construct 'URL': Invalid URLerror. I interpret this to mean that we were failing to instantiate a variable with a URL type because thenew URL()function takes a single argument (which cannot be null). Open to other, cleaner fixes.Tested locally with the Vite dev server proxied against my livenet planet.
PR Checklist